Save and restore whether pitch and tempo are unhooked or not#3043
Merged
TobiGr merged 4 commits intoTeamNewPipe:devfrom Feb 22, 2020
Merged
Save and restore whether pitch and tempo are unhooked or not#3043TobiGr merged 4 commits intoTeamNewPipe:devfrom
TobiGr merged 4 commits intoTeamNewPipe:devfrom
Conversation
"Unlink" is not an english word, and "Unhook" is used everywhere in the code
Collaborator
|
Thanks @Stypox for this PR, debug apk working smoothly as intended. I am going to use this for daily basis for days. Remembering speed/pitch-coupling checkbox state & having the unlink checked as default behaviour It is good to go👍 |
Collaborator
|
Possibilities discussed in #735 issue & in #1823 can be touched later as this PR is such a simpler fix for the time being. I personally feel "If the altered playback speed itself is remembered across videos" (atleast until closing the app) that would be a big +1. |
Collaborator
|
@TobiGr is this going to be added in 0.18.3 ? |
Member
Author
|
@gillhash No, this will probably be postponed to 0.18.4 |
TobiGr
approved these changes
Feb 22, 2020
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the
PlaybackParameterDialogsaves in SharedPreferences the state of the "Unhook" checkbox, so that the user does not have to slide down and click on the unhook checkbox every time. This is one of the proposed solutions in #1536. The other proposed solution was to make the checkbox checked by default, and based on the current pr code it could be implemented just by resetting the saved unhook preference totrueevery time a player is opened, but I think save&restore is better because not every user needs unhook-by-default.I also fixed the
unhook_checkboxstring, to make it more English-y.Fixes #1536
Debug apk: app-debug.zip